feat(writer): zone-map F16 columns + fully cover the stat-column code#125
Merged
Conversation
F16 columns do carry min/max stats (serialised as f32 scalars), so they are zone-mappable like every other primitive — drop the F16 exclusion and the now-always-true isZoneMappable gate, and re-pack F16 min/max to float16 storage in the stats table. Also tightens the new code to full coverage: parameterized test over every PType exercises each stat-column arm; added zero-chunk and chunk-without- stats guard tests; simplified the scalar decoders (ternary instead of dead throws) and threaded IOException instead of a dead catch. 1587 writer/reader tests green; Rust JNI interop unchanged. Co-Authored-By: Claude Opus 4.8 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
F16 columns do carry min/max stats (serialised as f32 scalars), so they
are zone-mappable like every other primitive — drop the F16 exclusion and
the now-always-true isZoneMappable gate, and re-pack F16 min/max to
float16 storage in the stats table.
Also tightens the new code to full coverage: parameterized test over every
PType exercises each stat-column arm; added zero-chunk and chunk-without-
stats guard tests; simplified the scalar decoders (ternary instead of dead
throws) and threaded IOException instead of a dead catch.
1587 writer/reader tests green; Rust JNI interop unchanged.
Co-Authored-By: Claude Opus 4.8 [email protected]